Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coloring for completion of Color components #92874

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 7, 2024

(Continuation of #74809)

изображение

@Chaosus Chaosus requested a review from a team as a code owner June 7, 2024 15:02
@Chaosus Chaosus modified the milestones: 4.4, 4.x Jun 7, 2024
@Chaosus Chaosus force-pushed the completion_color_color branch from f184535 to 305b948 Compare June 7, 2024 15:36
@fire fire requested a review from a team June 14, 2024 04:23
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 71699e0), it works as expected.

image

@Mickeon
Copy link
Contributor

Mickeon commented Jun 23, 2024

Using the axes colours makes sense, but feels somewhat "janky". Would it be worth to add other theme colours?

@Calinou
Copy link
Member

Calinou commented Jun 23, 2024

Using the axes colours makes sense, but feels somewhat "janky". Would it be worth to add other theme colours?

We could have generic editor colors that can be reused, similar to what #77114 adds for its own needs.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 24, 2024
@akien-mga akien-mga merged commit 6882a94 into godotengine:master Jun 24, 2024
16 of 17 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the completion_color_color branch June 24, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants