-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve colors' appearance in the editor's print_rich()
output
#77114
base: master
Are you sure you want to change the base?
Improve colors' appearance in the editor's print_rich()
output
#77114
Conversation
4a0c40b
to
81cfa0d
Compare
I approve the idea but IMO I feel like some colors, especially red and green, are a bit washed out. Could they be saturated a little bit more? Look at VSCode in comparison. |
I've reused the editor's error (red), warning (yellow) and success (green) colors. The blue color is based on the default accent color (but it does not change if you customize the accent color). I guess we could make those colors more saturated to match the increased icon saturation in 4.0. |
Oh, I see, so this is a more general problem. I'd saturate everything honestly. The question then becomes: do we saturate everything in one PR or in two parts (default and |
These can be done independently, so I think it's best to do that in a separate PR. We may want to further tweak the light theme colors for those as well. |
@Calinou all right. |
7379760
to
c5f6e99
Compare
c5f6e99
to
cabe476
Compare
cabe476
to
2e39b6d
Compare
This matches most terminals' behavior which don't use "pure" ANSI colors anymore, but use modern color palettes instead. Co-authored-by: Danil Alexeev <[email protected]>
2e39b6d
to
ebb6f98
Compare
Rebased and tested again, it works as expected. This PR now incorporates @dalexeev's BBCode replacement method, so I added them as a co-author. |
This matches most terminals' behavior which don't use "pure" ANSI colors anymore, but use modern color palettes instead. This improves readability and allows the colors to adapt to a light-theme editor.
Testing project: test_richtextlabel_color_alias.zip
Preview
How it looks like in VS Code's integrated terminal for comparison (using the default Dark Modern theme):