Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect cull boundary for scaled and repeated Parallax2D children #92763

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix incorrect cull boundary for scaled and repeated Parallax2D children #92763

merged 1 commit into from
Jun 12, 2024

Conversation

markdibarry
Copy link
Contributor

@markdibarry markdibarry commented Jun 4, 2024 •
edited
Loading

Fixes #92705

If there's a way to do this with less division, please let me know.

@markdibarry markdibarry requested a review from a team as a code owner June 4, 2024 15:56
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 4, 2024
@akien-mga akien-mga requested a review from lawnjelly June 11, 2024 07:57
lawnjelly
lawnjelly approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks superficially okay to me as I'm pinged.

Caveat, I'm not super familiar with 4.x renderer so not familiar with the "grand design".

@akien-mga akien-mga requested a review from clayjohn June 11, 2024 14:58
akien-mga
akien-mga approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks fine to me, and I know Clay has a lot on his plate to review, so I'll go ahead and merge so we have this tested in beta 2.

@akien-mga akien-mga merged commit 7571f82 into godotengine:master Jun 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@markdibarry markdibarry deleted the parallax2d_cull_fix branch June 12, 2024 12:28
@kleonc kleonc mentioned this pull request Jun 12, 2024
Merged
@markdibarry markdibarry mentioned this pull request Jun 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawnjelly lawnjelly lawnjelly approved these changes

@akien-mga akien-mga akien-mga approved these changes

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
bug topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Parallax2D's Sprite2D child stops rendering while scaled and zoomed on
4 participants
@markdibarry @akien-mga @lawnjelly @AThousandShips