-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix web export state for Remote Debug #92163
Fix web export state for Remote Debug #92163
Conversation
7ea34f6
to
42a4e1c
Compare
8c266ea
to
fa26281
Compare
For the record there's still time to merge this kind of bugfix in 4.3, especially as it's (partially?) a regression fix compared to 4.2, IINM. |
fa26281
to
0ddd810
Compare
This comment was marked as resolved.
This comment was marked as resolved.
50b00b9
to
e0181db
Compare
e0181db
to
1e8e9f4
Compare
-- @patwork in the developers chat I investigated the issue and it is a bug, a bug even shared with other exporters. But my quick fix leads to other issues, such as the export buttons being greyed out even if there's a valid debug template. @akien-mga, I suggest that we merge this PR, and I'll create an issue on the tracker about the reported bug. I don't think it's urgent to fix this issue for 4.3. |
The quick fix in question is this one: diff --git a/platform/web/export/export_plugin.cpp b/platform/web/export/export_plugin.cpp
index d83e465e8e..dd7235bc6e 100644
--- a/platform/web/export/export_plugin.cpp
+++ b/platform/web/export/export_plugin.cpp
@@ -413,7 +413,7 @@ bool EditorExportPlatformWeb::has_valid_export_configuration(const Ref<EditorExp
}
}
- valid = dvalid || rvalid;
+ valid = (p_debug && dvalid) || (!p_debug && rvalid);
r_missing_templates = !valid;
if (!err.is_empty()) {
|
Thanks! |
Fixes #92162 and simplifies the export plugin code (no need to resort converting a boolean to an int, then incrementing it).