Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shader highlighting the interruption in color_region caused by disabled_branch_regions. #91497

Merged
merged 1 commit into from
May 13, 2024

Conversation

magian1127
Copy link
Contributor

@magian1127 magian1127 commented May 3, 2024

When color_regions[0].p_start_key.length() > 2, disabled_branch_region causes color_region to break.
This should be seen as a temporary solution.

fix #91424

@magian1127 magian1127 requested a review from a team as a code owner May 3, 2024 04:45
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with the workaround for now, but it would be good to find a more robust solution later on.

@akien-mga akien-mga merged commit 194c940 into godotengine:master May 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shader syntax highlighting breaks when preprocessor variable is undefined (regression 4.3-dev6)
3 participants