GDScript: Perform validated calls with static methods

[vnen]

When the types are validated at compile time, this type of call runs faster. It is already used for instance methods, this adds this optimization to native static methods as well.

PS: Viewing the diff without whitespace makes it easier to review the changes. The opcodes table increased by one character, so the alignment creates a bigger diff.

[dsnopek]

Thanks!

I'm not really qualified to review the code changes, since I don't know GDScript's internals very well.

However, I did try using this PR with godot-cpp's automated tests, which includes some static method calls that GDScript should do as validated calls. To be sure that a validated call to GDExtension was happening, I added some debug print statements:

diff --git a/core/extension/gdextension.cpp b/core/extension/gdextension.cpp
index 22a5df9935..a1c4606c80 100644
--- a/core/extension/gdextension.cpp
+++ b/core/extension/gdextension.cpp
@@ -259,6 +259,10 @@ public:
                ERR_FAIL_COND_MSG(vararg, "Vararg methods don't have validated call support. This is most likely an engine bug.");
                GDExtensionClassInstancePtr extension_instance = is_static() ? nullptr : p_object->_get_extension_instance();
 
+               if (is_static()) {
+                       print_line("validated_call: ", name);
+               }
+
                if (validated_call_func) {
                        // This is added here, but it's unlikely to be provided by most extensions.
                        validated_call_func(method_userdata, extension_instance, reinterpret_cast<GDExtensionConstVariantPtr *>(p_args), (GDExtensionVariantPtr)r_ret);

And, it printed out the function names I was expecting, as well as passed the tests!

[Bromeon]

I tested this in Rust, and it works, great job!

Interesting discovery: before this PR, static methods do use ptrcall if they are called as instance methods (on an object, rather than a type).

[Bromeon]

Not directly related to this PR, but is it possible to call static methods via reflection? I wanted to simulate falling back to regular calls (if no type information is available), but found it's only possible via actual instances.

[akien-mga]

Thanks!