Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use vscroll when fit to content height in TextEdit #91190

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Apr 25, 2024

The horizontal scrollbar part was fixed in #83286

This makes sure that the vertical scroll bar won't be shown when fit to content height.
This fixes the crash mentioned in the issue. #80546 had a slightly different cause for the crash, which was fixed. This crash only happens at certain sizes depending on the text and is rarer.
This fixes it since in _update_wrap_at_column, the v_scroll size is used, which is then removed next time it is updated, causing an infinite loop.

@kitbdev kitbdev requested a review from a team as a code owner April 25, 2024 23:27
@YeldhamDev YeldhamDev added this to the 4.3 milestone Apr 26, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 26, 2024
@akien-mga akien-mga requested review from KoBeWi and bruvzg April 26, 2024 08:03
@akien-mga akien-mga merged commit 1c584ec into godotengine:master Apr 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the dont-scroll-if-fit branch April 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release regression topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextEdit with autowrap and fit content height does not work correctly
3 participants