Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextEdit with autowrap and fit content height does not work correctly #81764

Closed
KoBeWi opened this issue Sep 16, 2023 · 3 comments · Fixed by #91190
Closed

TextEdit with autowrap and fit content height does not work correctly #81764

KoBeWi opened this issue Sep 16, 2023 · 3 comments · Fixed by #91190
Assignees
Milestone

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Sep 16, 2023

Godot version

4.2 dev4

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

When you set TextEdit's wrap mode to boundary and enable scroll_fit_content_height, the TextEdit is expected to never show scrollbars. But it does show scrollbars at certain sizes, both horizontal and vertical.

godot.windows.editor.dev.x86_64_CSyM4ZoUMl.mp4

I remember this worked seamlessly when the fit content feature was first added.

Moreover, if the text is sufficiently long, it can freeze at certain sizes.

ded.mp4

(also notice how horizontal scroll appears despite using autowrap)

EDIT:
Seems like #80546 covers the freeze (crash) part. But the scrollbar bug is still relevant here.

Steps to reproduce

  1. Add TextEdit
  2. Set wrap_mode to Boundary
  3. Enable scroll_fit_content_height
  4. Put any text longer than ~10 words
  5. Resize

Minimal reproduction project

N/A

@bitsawer
Copy link
Member

Looks like a duplicate of #80546

@KoBeWi KoBeWi changed the title TextEdit with autowrap and fit content height does not work correctly and may freeze app TextEdit with autowrap and fit content height does not work correctly Sep 16, 2023
@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 16, 2023

I edited the issue, it's only a partial duplicate.

@matheusmdx
Copy link
Contributor

Bisecting shows that issue started after #74813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants