Fix errors/crashes related to skipped imports #91078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Apr 25, 2024
KoBeWi
approved these changes
Apr 25, 2024
- Added check for "animation/fps" key before attempting to use it in EditorSceneFormatImporterBlend::import_scene, to give error instead of crashing - Don't show "Advanced..." button if last import used "Keep File" or "Skip File" - Don't try to call ResourceLoader::load on kept/skipped file when changing importer, which would give an error Fixes godotengine#90324
aaronp64
force-pushed
the
import_skip_crash
branch
from
3443633 to
e63d098
Compare
akien-mga
added
the
cherrypick:4.2
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for "animation/fps" key before attempting to use it in
EditorSceneFormatImporterBlend::import_scene, to give error instead of crashingDon't show "Advanced..." button if last import used "Keep File" or "Skip File"
Don't try to call
ResourceLoader::loadon kept/skipped file when changing importer, which would give an errorFixes #90324