Fix duplicated folder reference in Godot Editor after changing filename case #90280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Apr 6, 2024
akien-mga
added
the
cherrypick:4.2
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76021
EDIT: Also apparently fixes #22475
If the folder a Scene was in had the case of its name changed changed (either through deleting and recreating it in the editor, or changing in the OS), then in case-insensitive OS platforms (Windows, recent MacOS), saving that Scene would create duplicate folder references in the Godot editor.
This fixes that by checking whether the base folder of the Godot project is case sensitive or insensitive when seeing whether a new Editor folder will need to be created on Scene save.