-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godot allow to exist folders with the same name - e.g. AAA and aaa on windows #22475
Comments
Wouldn't allowing this break things on other OS's that don't distinguish between capitalization of folders? |
@dualmatrix I believe that windows is the only OS around that thinks 'file_or_folder_name' and 'FiLe_Or_FoLdEr_NaMe' are the same. Although NTFS can be configured to be case sensitive, it is turned off by default. |
I think that the Script Create Dialog should probably not be allowed to create folders on its own like this based on a manually typed path. There might be other ways to create such folder names with different case on Windows though that need to be handled at the Dir/FileAccess level probably. |
Some of the macOS file systems default to a case insensitive mode.
|
@akien-mga It actually can't create folders on its own. If the destination directory doesn't exist, then the create script dialog will display an "Invalid path" error. Even if that wasn't the case, partial paths where directories exist should be resolving to FS directories. |
Looks like a UI issue, not a directory creation issue. |
Just Random Info: Case sensitivity on Windows 10 is an NTFS system feature that can be enabled on a per-directory basis. This means that it wouldn't apply to your entire file system. That said, you can only add the feature to specific folders for development purposes. Case sensitivity on Windows 10 was included in the April 2018 Update. |
The link to the video seems dead so basically I can still reproduce this in Godot 3.3.2 on Windows by doing this:
Other attempts at explicitely creating the Note: the dialog might not be responsible for this (although I have doubts about what happens in step 3)), but rather the code that reacts to the submission of the dialog. |
Different repo steps, but I believe this bug is a duplicate of #76021 I've submitted a PR that fixes that issue, and seems to fix this one too. |
Godot version:
3.1 8fc92ae
OS/device including version:
Windows 10
Issue description and Steps to reproduce:
When I have folder with name AAA I can't create folder with aaa, but when I create script and put it in new folder which have name aaa, godot create it and shouldn't do this.
https://streamable.com/kcjrz
The text was updated successfully, but these errors were encountered: