Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project Manager] Replace title bar logo with color variant. #90080

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 31, 2024

Alternative to #89969, uses default color logo instead of outline one.

HiDPI:

LowDPI:

It looks fine at 200% scale, a bit blurry at lower scales, but with logo aligned to pixel grid it's not completely broken even an 75% scale.

100% UI scale (zoom):
Screenshot 2024-03-31 at 21 30 07

75% UI scale (zoom):
Screenshot 2024-03-31 at 21 30 45

Bugsquad edit:

@bruvzg bruvzg added this to the 4.x milestone Mar 31, 2024
@bruvzg bruvzg requested a review from a team as a code owner March 31, 2024 18:43
@ajreckof
Copy link
Member

ajreckof commented Apr 1, 2024

I feel like this is the best of all propositions given for replacing the logo here.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We could consider drawing special pixel art versions of the logo for smaller scales (to be swapped in depending on editor scale), but this should be left for a future PR.

@bruvzg
Copy link
Member Author

bruvzg commented Apr 3, 2024

We could consider drawing special pixel art versions of the logo for smaller scales (to be swapped in depending on editor scale), but this should be left for a future PR.

That will be useful for native icons (macOS and Windows icons are raster) as well (at least for small sizes like 16x16 and 32x32, which are blurry).

@coppolaemilio
Copy link
Member

Looking sharp! How does this look in Windows?

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 4, 2024
@bruvzg
Copy link
Member Author

bruvzg commented Apr 4, 2024

How does this look in Windows?

150 and 100 % scale:
Screenshot 2024-04-04 152638

@akien-mga akien-mga merged commit d2bd818 into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the color_title_logo branch May 31, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the logo in the new Project Manager to one of the official versions
6 participants