-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Project Manager] Replace title bar logo with color variant. #90080
Conversation
I feel like this is the best of all propositions given for replacing the logo here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We could consider drawing special pixel art versions of the logo for smaller scales (to be swapped in depending on editor scale), but this should be left for a future PR.
That will be useful for native icons (macOS and Windows icons are raster) as well (at least for small sizes like 16x16 and 32x32, which are blurry). |
Looking sharp! How does this look in Windows? |
Thanks! |
Alternative to #89969, uses default color logo instead of outline one.
HiDPI:
LowDPI:
It looks fine at 200% scale, a bit blurry at lower scales, but with logo aligned to pixel grid it's not completely broken even an 75% scale.
100% UI scale (zoom):
75% UI scale (zoom):
Bugsquad edit: