Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project Manager] Simplify title bar logo. #89969

Closed
wants to merge 1 commit into from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 28, 2024

Removes inverted face part of the title bar logo:

  • It's ugly and distracting (too much contrast).
  • It's taking too much space.
  • It's inconsistent with other Godot logos style.
  • It's duplicating the native title bar icon on Windows (and probably many Linux DEs).
Screenshot 2024-03-28 at 00 07 57 Screenshot 2024-03-28 at 00 08 52

Related proposal godotengine/godot-proposals#9065

@bruvzg bruvzg added this to the 4.x milestone Mar 28, 2024
@bruvzg bruvzg requested a review from a team as a code owner March 28, 2024 05:59
Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, this looks much cleaner :)

@groud
Copy link
Member

groud commented Mar 28, 2024

hmm. While I believe this is step in the right direction, we've never used the logo's text alone before. It looks very out of place to me.

I'd rather keep the logo and use the usual blue version instead, or completely remove the logo. But I'd prefer to avoid replacing an inconsistency in our branding by another inconsistency.

@bruvzg
Copy link
Member Author

bruvzg commented Mar 28, 2024

I'd rather keep the logo and use the usual blue version instead, or completely remove the logo.

  • The blue logo is too detailed and will look blurry at this scale.
  • Removing the logo will leave an asymmetric hole in the UI, also logo acts as "About" button (so in this case will need to re-add it in some other place).

@MewPurPur
Copy link
Contributor

MewPurPur commented Mar 28, 2024

By the way, I toned down the pure white color to #e0e0e0 (standard icon color) in #89711, so this already has less contrast than it does in the latest dev build.

@bruvzg
Copy link
Member Author

bruvzg commented Mar 28, 2024

or completely remove the logo

Or maybe we should replace it with something more neutral (and more useful), like help menu:

Screen.Recording.2024-03-28.at.20.15.51.mov

@groud
Copy link
Member

groud commented Mar 28, 2024

The blue logo is too detailed and will look blurry at this scale.

I am not sure it would TBH, it just needs the SVG correctly rendered to that scale I believe. At least it seems to work well enough in the windows taskbar.

@timothyqiu
Copy link
Member

or completely remove the logo

Clicking the version on the bottom right can summon the about dialog instead of simply coping the version text.

@bruvzg
Copy link
Member Author

bruvzg commented Mar 29, 2024

I am not sure it would TBH, it just needs the SVG correctly rendered to that scale I believe.

Tested it, and at least on the high DPI screen it seems to be better than I expected (will check on a low DPI later), so it might be an option.

Screenshot 2024-03-29 at 22 58 59

@bruvzg
Copy link
Member Author

bruvzg commented Mar 31, 2024

Tested it, and at least on the high DPI screen it seems to be better than I expected (will check on a low DPI later), so it might be an option.

Played a bit with a logo alignment and scale, and it seems to be more or less OK (at least less ugly) - #90080

@akien-mga
Copy link
Member

Superseded by #90080 which is more in line with the logo brand guidelines.

@akien-mga akien-mga closed this Apr 4, 2024
@AThousandShips AThousandShips removed this from the 4.x milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants