Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak OpenXR alert to mention WMR only on Windows #89968

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 28, 2024

WMR isn't supported on non-Windows platforms, so there's no point in mentioning it in the error message as it's not a possible cause for OpenXR not initializing.

WMR isn't supported on non-Windows platforms, so there's no point
in mentioning it in the error message as it's not a possible
cause for OpenXR not initializing.
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 28, 2024
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I wonder if we should be specifically mentioning "SteamVR" when the "Oculus" runtime would also be a valid choice here? But I don't think we need to solve that on this PR - these changes would already be an improvement. :-)

@akien-mga akien-mga merged commit 1469db5 into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants