Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EXIT_SUCCESS on Android #89887

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix EXIT_SUCCESS on Android #89887

merged 1 commit into from
Mar 25, 2024

Conversation

Alex2782
Copy link
Member

Fixes: #89886

@Alex2782 Alex2782 requested a review from a team as a code owner March 25, 2024 16:52
m4gr3d
m4gr3d approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

This issue seems to have affected a couple platforms, were you able to trace the root cause and do we need to propagate this fix to other platforms?

@m4gr3d m4gr3d added this to the 4.3 milestone Mar 25, 2024
@Alex2782
Copy link
Member Author

Alex2782 commented Mar 25, 2024 •
edited
Loading

MacOS fixed yesterday. Web, Windows, iOS looks ok. -> #89842

original PR with more informations: #89229

akien-mga
akien-mga approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

And my bad, thanks for the fixes. I also confirm that the other uses of Main::start() seem fine now.

@akien-mga akien-mga merged commit 7c6e85d into godotengine:master Mar 25, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Alex2782 Alex2782 deleted the fix_exit_code_on_android branch March 25, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:android regression topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Regression: exit code EXIT_SUCCESS causes an infinite loop on Android
4 participants
@Alex2782 @akien-mga @fire @m4gr3d