Crash on launch on the mac

[fire]

Tested versions

• Reproducible in master 99ff024
• Not in 4.3 dev4

System information

Mac Mini, Apple Silicon

Issue description

% git bisect bad                   
023dcd44c1e628bb654b5472418d6a346b510a71 is the first bad commit
commit 023dcd44c1e628bb654b5472418d6a346b510a71
Author: Rémi Verschelde <[email protected]>
Date:   Wed Mar 6 18:50:35 2024 +0100

    Refactor OS exit code to be `EXIT_SUCCESS` by default
    
    - `Main::setup` early exits (failure or `--help`/`--version`) now
      consistently return `EXIT_FAILURE` or `EXIT_SUCCESS` on all platforms,
      instead of 255 on some and a Godot Error code on others.
    - `Main::start` now returns the exit code, simplifying the handling of early
      failures.
    - `Main::iteration` needs to explicit set the exit code in OS if it errors
      out.
    - Web and iOS now properly return `OS::get_exit_code()` instead of 0.

 core/os/os.h                         |  3 +-
 main/main.cpp                        | 96 ++++++++++++++++--------------------
 main/main.h                          |  2 +-
 platform/ios/godot_ios.mm            | 11 +++--
 platform/linuxbsd/godot_linuxbsd.cpp | 13 ++---
 platform/macos/godot_main_macos.mm   | 19 ++++---
 platform/web/web_main.cpp            | 16 +++---
 platform/windows/godot_windows.cpp   |  8 +--
 8 files changed, 82 insertions(+), 86 deletions(-)

Godot Engine is crashing on launch on the mac. There is no crash log.

Steps to reproduce

Start godot and watch it crash.

I used scons scu_build=yes compiledb=yes

Minimal reproduction project (MRP)

N/A

[Alex2782]

Main::start() -> return EXIT_SUCCESS; and not more return true;

#define EXIT_SUCCESS 0

godot/platform/macos/godot_main_macos.mm

Line 83 in 99ff024

if (ret) {

Fix:

	if (ret == EXIT_SUCCESS) {
		os.run();
	} else {
		os.set_exit_code(EXIT_FAILURE);
	}