Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enter shortcut to add a shader global in the editor #89184

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 5, 2024


  • Clear the shader global name field when adding a new shader global to match the behavior of other tabs in the Project Settings dialog.

Preview

This is done entirely with the keyboard.

simplescreenrecorder-2024-03-05_16.02.42.mp4

@Calinou Calinou added this to the 4.x milestone Mar 5, 2024
@Calinou Calinou requested a review from a team as a code owner March 5, 2024 15:05
editor/shader_globals_editor.cpp Outdated Show resolved Hide resolved
editor/shader_globals_editor.h Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the shader-globals-editor-add-enter-shortcut branch from b5518f8 to a219299 Compare March 5, 2024 18:22
- Clear the shader global name field when adding a new shader global
  to match the behavior of other tabs in the Project Settings dialog.
@Calinou Calinou force-pushed the shader-globals-editor-add-enter-shortcut branch from a219299 to 3051920 Compare March 5, 2024 18:22
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 5, 2024
@akien-mga akien-mga merged commit 3dff0e9 into godotengine:master Mar 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the shader-globals-editor-add-enter-shortcut branch March 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants