-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ctrl + L / Cmd + Shift + G shortcut to focus path bar in FileDialog #81177
Add Ctrl + L / Cmd + Shift + G shortcut to focus path bar in FileDialog #81177
Conversation
I guess it's the closest thing, there's no path bar in the native file dialog, and |
Works on Windows. Don't see why it wouldn't work on macOS based on the code, and comment above. 2024-01-15.10-15-20.mp4 |
@Calinou Works on mac, but if the focus is inside of the window it also selects the folder that starts with Screen.Recording.2024-01-15.at.19.27.41.mp4 |
It is the correct shortcut in Finder, but I'm not sure if a lot of people know it exists. I keep forgetting that shortcut and I've been using macs on and off for over a decade 🙂 I recommend using |
It's strange this happens, as the code specifically marks the input as handled by calling |
b9307ed
to
a9cc583
Compare
I've added Cmd + L on macOS in addition to the existing Cmd + Shift + G there. Ctrl + L / Cmd + Shift + G can also now be used to focus on the property name in the project settings editor (or the "add input" box in the input action editor). |
a9cc583
to
d0e70d4
Compare
Yes 🙂 I thought about focusing Filter by event instead, but am not sure how often you'd need to focus on that box in comparison (while quickly focusing on Add New Action can be very useful to add many inputs at once). |
I got everything to work except that, it doesn't seem to focus anything. |
Everything works on my end, including the "Add New Action" |
Ah weird, I rebuilt and it's working on my end too. My bad. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. As commented in project settings editor, more tabs could use the shortcut.
This also tweaks EditorFileDialog to use the same shortcut, while making it select the path text after focusing (like in most file managers). Ctrl + L / Cmd + Shift + G can also now be used to focus on the property name in the project settings editor, as well in the Input Map, Autoload, Shader Globals and Global Groups tabs.
d0e70d4
to
4f8d7ca
Compare
Done (see the updated PR description for details). |
Thanks! |
This also tweaks EditorFileDialog to use the same shortcut, while making it select the path text after focusing (like in most file managers).
Ctrl + L / Cmd + Shift + G can also now be used to focus on the property name in the project settings editor, as well in the Input Map, Autoload, Shader Globals and Global Groups tabs.
Testing project: test_filedialog_focus_shortcut.zip