Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DisplayServer] Add error messages and descriptions to callbacks. #89033

Merged
merged 1 commit into from
May 28, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 1, 2024

Fixes #89022

Adds error messages to the system theme change, status indicator and drop files callbacks.

@bruvzg bruvzg added this to the 4.3 milestone Mar 1, 2024
@bruvzg bruvzg marked this pull request as ready for review March 1, 2024 21:23
@bruvzg bruvzg requested review from a team as code owners March 1, 2024 21:23
doc/classes/DisplayServer.xml Outdated Show resolved Hide resolved
doc/classes/DisplayServer.xml Outdated Show resolved Hide resolved
@Mickeon Mickeon self-requested a review March 1, 2024 21:54
@akien-mga
Copy link
Member

Needs rebase and addressing the doc review, otherwise should be fine to merge I think.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Needs a last rebase before merge.

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation changes LGTM, code does too at a glance, but I haven't looked at it for long.

@akien-mga
Copy link
Member

Poke for rebase.

@akien-mga akien-mga merged commit c98fef0 into godotengine:master May 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tray status indicator callback doesn't error when it doesn't take correct parameters / Missing documentation
5 participants