Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot Editor stutters randomly due to the editor theme being unnecessarily regenerated #95575

Closed
Yni-Viar opened this issue Aug 15, 2024 · 3 comments · Fixed by #95849
Closed

Comments

@Yni-Viar
Copy link

Yni-Viar commented Aug 15, 2024

Tested versions

  • Reproducible in 4.3 after 714effd
  • Not reproducible in 4.3 before 714effd , 4.2.2

System information

Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 Ti (NVIDIA; 32.0.15.6081) - Intel(R) Core(TM) i5-10400F CPU @ 2.90GHz (12 Threads)

Issue description

I got upgraded my projects to Godot 4.3 from 4.2.2 and noticed, that it stutters randomly (I tested 4.3 Dev 6 and 4.2.2 stable - no issues) if V-Sync is enabled.
Godot 4.3 Beta 2, RC 2 and 3 partially trigger this bug.
Below I posted --verbose log, what Godot did when it was stuttering

EditorTheme: Generating new theme for the config '66886095'.
EditorTheme: Can keep old icons, copying.
EditorTheme: Generating new fonts.
EditorTheme: Generating new styles.

изображение

Steps to reproduce

For 4.3.stable: Create empty project -> open the editor -> see stutter randomly
For 4.3 Beta 1, Beta 2, RC 2 and 3: Create empty project -> open the editor -> set V-Sync to enabled/adaptive in editor settings -> zoom in and out repeatedly (when window is inactive) -> see stutter randomly

Minimal reproduction project (MRP)

Mostly unneeded, occurs even in empty project.
Here I leave the example one, created in 4.3.stable
test.zip

@Yni-Viar Yni-Viar changed the title Godot Editor stutters randomly if V-Sync enabled Godot Editor stutters randomly Aug 16, 2024
@Yni-Viar
Copy link
Author

Edit: in large projects editor stutters even if V-Sync disabled.

@Yni-Viar
Copy link
Author

The bug likely was introduced between 4.3 dev 6 and beta 1.

@Yni-Viar
Copy link
Author

Yni-Viar commented Aug 19, 2024

I investigated into the problem, and found, that #89033 is the source of bug. (I debugged stable version) Also I checked build before commit (no issues) and after commit (the bug is triggered).
2024-08-19 125237
2024-08-19 124740
(screenshots from 4.3.stable)

@akien-mga akien-mga added this to the 4.4 milestone Aug 19, 2024
@akien-mga akien-mga moved this from Unassessed to Bad in 4.x Release Blockers Aug 19, 2024
@Calinou Calinou changed the title Godot Editor stutters randomly Godot Editor stutters randomly due to the editor theme being unnecessarily regenerated Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment