-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running tests in template builds #88452
Conversation
tests
with dev_mode
without editortests = true
with dev_mode
without editor
tests = true
with dev_mode
without editordev_mode
without editor
8b4304c
to
955e4db
Compare
This comment was marked as outdated.
This comment was marked as outdated.
What are the issues? In theory it seems useful to me that we can run unit tests on non-tools builds (especially the release template), to validate that the API behaves as intended even in release builds. It's not something we would enable for official export templates of course, but ideally we would run such tests on CI. If some tests depend on editor-only functionality, they should be |
Indeed, will look deeper into the specific issues, but there are some tests that simply won't work without even being in the correct directory, but will leave this for later digging and not add it here Note that we couldn't use it in CI unless we do an export completely as the template binary can't be run then |
|
That's strange it popped up the dialog for me first, you're right it works fine in that case, then no worries here, then I'll just leave it as such for now :) |
Well actually in second thought, since |
I'll take a look :) |
955e4db
to
f1cbcf9
Compare
dev_mode
without editor
Identified the first issue, the file |
For now I'm disabling some of the offending GDScript tests, to be fixed later, and fixing some other tests and improving them, will push soon |
f1cbcf9
to
1b98d72
Compare
1b98d72
to
d7a72d7
Compare
There, some temporary fixes in there but this makes it possible to generally run tests, with some improvements There are still some test cases that fail on |
Thanks! |
Thank you! |
No description provided.