Fix for Exported typed variables in a tool script have wrong initial value if not initialized #92114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hilderin
changed the title
Hilderin
force-pushed
the
fix_default_value_not_initialized
branch
4 times, most recently
from
821fbab to
bbf4498
Compare
…value if not initialized godotengine#62363
Hilderin
force-pushed
the
fix_default_value_not_initialized
branch
from
bbf4498 to
8bb249b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #62363
The problem was caused by
member_default_values_cachenot initialized for tool scripts. When not a tool script, a PlaceHolder is created and_update_exportswas called. But_update_exportswas not called on the creation of GDScriptInstance. Later when the scene or the script is saved,_update_exportsis called fixing the issue after the first save. So to fix the problem, I added a call to_update_exportswhen the GDScriptInstance is created.