Fix various bugs in Animation key right click actions #88445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookieBadger
force-pushed
the
animation-paste-snap-fix
branch
from
83e0d93 to
e8923cc
Compare
akien-mga
changed the title
|
Could you amend the commit message to make it explicit that it's about animation? The current PR title would be a good option. See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#be-mindful-of-your-commits for details. |
CookieBadger
force-pushed
the
animation-paste-snap-fix
branch
from
e8923cc to
2e42cbe
Compare
|
@akien-mga of course, sorry for that. Changed commit message to match PR title. |
CookieBadger
force-pushed
the
animation-paste-snap-fix
branch
from
2e42cbe to
1f300cd
Compare
|
rebased on top of 5f05e2b |
CookieBadger
force-pushed
the
animation-paste-snap-fix
branch
from
1f300cd to
0413152
Compare
|
rebased on top of b714563 |
|
@AThousandShips any chance this PR is reviewed soon? |
|
No clue, the animation team is requested and will take a look when they can CC @godotengine/animation |
TokageItLab
approved these changes
Mar 16, 2024
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
Fix various bugs in Animation key right click actions
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the features implemented in #87250 from the right-click context menu, they should snap with the current snap steps, same as when inserting a key. They should now work properly in the negative time area, too. Also, there was an error when inserting a key, selecting it, and then performing an undo, that is fixed by these changes.