Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting 3.x material/# properties on MeshInstance3D #88078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −2
Open

Support setting 3.x material/# properties on MeshInstance3D #88078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions scene/3d/mesh_instance_3d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,19 @@ bool MeshInstance3D::_set(const StringName &p_name, const Variant &p_value) {
return true;
}

if (p_name.operator String().begins_with("surface_material_override/")) {
int idx = p_name.operator String().get_slicec('/', 1).to_int();
String name = p_name;

#ifndef DISABLE_DEPRECATED
if (name.begins_with("material/")) {
WARN_DEPRECATED_MSG("This mesh uses an old deprecated parameter name. Consider re-saving this scene in order for it to continue working in future versions." +
(is_inside_tree() ? vformat(" Path: \"%s\"", get_path()) : String()));
}
if (name.begins_with("surface_material_override/") || name.begins_with("material/"))
#else
if (name.begins_with("surface_material_override/"))
#endif
{
int idx = name.get_slicec('/', 1).to_int();

if (idx >= surface_override_materials.size() || idx < 0) {
return false;
Expand Down
Loading