Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting 3.x material/# properties on MeshInstance3D #88078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikitalita
Copy link
Contributor

This PR introduces support for setting the old material/# properties on MeshInstance3D, which were renamed to surface_material_override/# in 4.x. This is only supported when using set() (i.e. during the initial load) and emits a warning when doing so.

Note that this should not conflict with ImporterMesh; This will only trigger if the property is named material/{num}. I have checked, and MeshInstance3D was the only resource that stored a property named material INI style in either 3.x or 4.x.

@fire
Copy link
Member

fire commented Feb 10, 2024

If it's not too much hassle can you provide a test sample?

@nikitalita
Copy link
Contributor Author

Here's an example I threw together: example_meshinstance3d_mesh.zip

Without this patch:
image
With this patch:
image

@nikitalita nikitalita force-pushed the MeshInstance3D-old-prop branch from b57b313 to 86895c1 Compare September 30, 2024 08:33
@nikitalita
Copy link
Contributor Author

@fire same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants