-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCons: Add proper MinGW support to D3D12 deps install script #87619
SCons: Add proper MinGW support to D3D12 deps install script #87619
Conversation
929e24c
to
4b2d798
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should update Mesa to the current release - 23.3.4 (GitHub mirror seems to be outdated, and active repo is https://gitlab.freedesktop.org/mesa/mesa/), and make a single release with both MinGW and MSVC files.
That would be nice yeah, it should simplify the script so we don't have to make assumptions, if we can just rely on |
4b2d798
to
c60a926
Compare
c60a926
to
c5ad9f2
Compare
c5ad9f2
to
c747184
Compare
Redid this PR now that https://github.com/godotengine/godot-nir-static/ has both MSVC and MinGW support in the same tarball. There's no more command line options, but instead we rely on whether we find |
c747184
to
8ebeec2
Compare
8ebeec2
to
64d8cb7
Compare
Tested locally on Windows 11 with llvm-mingw 20231128, it works as expected. The resulting D3D12 build can be run just fine. Note that if your llvm-mingw version is older (I had a version from 2022 lying around), I got the following output with it (but the
The script still works successfully if I rename my llvm-mingw folder so it's no longer in |
Fix a couple GCC warnings.
64d8cb7
to
5fd9d08
Compare
I'm not super happy about the change in
platform/windows/detect.py
to figure out whether to modify theenv["mesa_libs"]
path to add a-mingw
suffix...Open to suggestions to make this less hacky, especially having to pass the detected d3d12 deps path as an option, because we can't easily pass info otherwise from
get_opts
to the env orconfigure_mingw
(global
doesn't seem to work).Might also work on macOS to cross-compile, worth testing.