Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EditorTranslationParser to add POT comments #87401

Conversation

nathanhoad
Copy link

@nathanhoad nathanhoad commented Jan 20, 2024

This adds an optional fourth item to the msgids_context_plural array in EditorTranslationParserPlugin::parse_file that can be used to add comments to the generated POT file.

This means that anyone using the custom POT generation system can provide extra help for translators.

image

@AThousandShips
Copy link
Member

Please open a proposal to track the support and details of this feature 🙂

@nathanhoad
Copy link
Author

Please open a proposal to track the support and details of this feature 🙂

Done 👍 godotengine/godot-proposals#8917

Copy link

@molingyu molingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalexeev
Copy link
Member

@akien-mga
Copy link
Member

Superseded by #98099. Thanks for the contribution!

@akien-mga akien-mga closed this Nov 14, 2024
@akien-mga akien-mga removed this from the 4.x milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow EditorTranslationParserPlugins to provide comments for POT generation
5 participants