-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not commit transforms and handles if no changes were made #87161
Do not commit transforms and handles if no changes were made #87161
Conversation
0f6f662
to
fb7e2f2
Compare
Thoughts on avoiding the commit of transformations when no actual change to the transform values has occurred? This could improve the editor's performance by avoiding redundant actions, but I am not familiar with this code. |
Makes sense. |
fb7e2f2
to
0680de1
Compare
CollisionShape2D was an example, there are more 2D editors - Path2D, Polygon2D, Line2D, Raycast2D and possibly others. Hence it might not be as easy, because the code is not unified like in 3D. |
Yeah, I know it was a premature push, my bad. I'm working on fixing all of them. |
0680de1
to
32c89ab
Compare
A lot of these end up inheriting the same class, so it wasn't too bad. I went through all the 2D nodes to see if I missed anything (clicked on any obvious handles, including with modifier keys), but I am admittedly not as familiar with 2D as I am with 3D, so let me know if I missed any. |
32c89ab
to
f2f3f17
Compare
Thanks! |
Currently left clicking without moving the mouse will commit a transform and handles unnecessarily flooding the output and history with transform messages. This PR checks that the mouse was moved, meaning a changed was made, before committing.