Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Path2D's add new point's UndoRedo bug #89874

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix Path2D's add new point's UndoRedo bug #89874

merged 1 commit into from
Apr 9, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #89781

Tested locally it works fine.

@jsjtxietian jsjtxietian requested a review from a team as a code owner March 25, 2024 07:29
@YeldhamDev YeldhamDev added this to the 4.3 milestone Mar 25, 2024
@akien-mga akien-mga requested a review from KoBeWi March 25, 2024 09:21
@KoBeWi

This comment was marked as resolved.

Sign in to view
@akien-mga
Copy link
Member

@KoBeWi The PR has been updated after your review.

KoBeWi
KoBeWi approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I forgot to approve after testing again, sorry.

@akien-mga akien-mga merged commit 78fade3 into godotengine:master Apr 9, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the path2d branch April 10, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Adding new points to Path2D and undoing it breaks scene history
4 participants
@jsjtxietian @KoBeWi @akien-mga @YeldhamDev