-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSR not working properly in stereo #86996
Conversation
3d88fa1
to
10a8b88
Compare
Remember to use closing keywords in the OP :) |
There are a lot more cases still using
|
Yep, those all seem to use |
Shouldn't we unify those so they all use the same name? |
We could, there would be no harm in doing it |
The compatibility renderer consistently uses |
Thanks, I always forget the syntax, so I just add it manually on the right side. |
And yes, I agree that we should unify these, thats probably how the bug got introduced. But I suggest we do that in a separate PR as a mistake will break stuff. |
Thanks! |
Cherry-picked for 4.2.2. |
Fix typo that caused #86987
Bugsquad edit: