-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for get_node
autocompletion
#86973
Conversation
A whooping 100 files added. Are they all truly necessary for the tests? |
Yeah the file count kinda exploded 😅. But every idea I have to reduce it seems worse.
If you have any other ideas to reduce it, I'm all in for it, that being said many test files aren't that big of a problem to justify any of the tradeoffs that I listed IMO. |
f0ab094
to
483f0cb
Compare
0cd365d
to
a1562d3
Compare
1e913f0
to
67cd3fc
Compare
Waiting for #87759 in order to fix the CI. |
67cd3fc
to
16231d9
Compare
e45abea
to
875a601
Compare
875a601
to
a2e7c64
Compare
get_node
autocompletionget_node
autocompletion
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a cursory look it is good to me. Thanks for working on this!
Thanks! |
Oh shit, I just noticed I forgot to squash the commits and now you merged it 😅. I guess it can't be changed now? |
Yeah I missed that. It can't be changed once merged. |
Requires #86961