Check the seeking if it is processed immediately after playback as a special case #85366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
TokageItLab
force-pushed
the
more-stable-seek-discrete
branch
from
849a8e0 to
4ce46fc
Compare
TokageItLab
force-pushed
the
more-stable-seek-discrete
branch
from
4ce46fc to
c36200b
Compare
KoBeWi
approved these changes
Nov 25, 2023
|
I have tested that it works at least for the project I fixed in #85221. I have also tested the project with some method tracks and it works, but I don't know about more advanced cases as I have not tested them. |
|
I've tested this on my project and it fixes the issue (Y) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
advance()has no effect on Discrete animation tracks and stops playback #85315#85221 solved the case right after the start by removing the flag. However, the old AnimationPlayer force retrieve current frame key when seeking immediate after start to playback as the special case, so make it match the behavior of the old AnimationPlayer.