[CI] Enable ANGLE static linking. #84175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
ci_static_angle
branch
from
827f45c to
f90efb1
Compare
bruvzg
force-pushed
the
ci_static_angle
branch
from
f90efb1 to
81b9b65
Compare
bruvzg
force-pushed
the
ci_static_angle
branch
from
81b9b65 to
6848afb
Compare
|
Removed macOS part, but it's still useful for Windows artifacts to have ANGLE linked (for testing on old AMD hardware). |
akien-mga
approved these changes
May 11, 2024
There was a problem hiding this comment.
Needs rebase and adjusting a few things, but otherwise seems good to me.
That being said, regarding #84075, should we consider adding a fallback from opengl3_angle to opengl3 if ANGLE libs are missing? Can be in a separate PR if we decide to do it.
| uses: dsaltares/[email protected] | ||
| with: | ||
| repo: godotengine/godot-angle-static | ||
| version: tags/chromium/6029 |
There was a problem hiding this comment.
6029.1 now?
It's macOS only (changes for using native GL). I never made 6029.1 build for Windows, since nothing changed.
|
Poke for rebasing. |
akien-mga
approved these changes
May 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84075