Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up/down inputs misbehaving in EditorSpinSlider #80551

Closed
wants to merge 1 commit into from
Closed

Fix up/down inputs misbehaving in EditorSpinSlider #80551

wants to merge 1 commit into from

Conversation

MewPurPur
Copy link
Contributor

Fixes up/down inputs sometimes using the real step when they shouldn't. Fixes one of the issues outlined in #76620

@YeldhamDev YeldhamDev added this to the 4.2 milestone Aug 12, 2023
@MewPurPur MewPurPur mentioned this pull request Sep 3, 2023
Merged
@Alex2782
Copy link
Contributor

Alex2782 commented Sep 3, 2023

I have tried your changes, for min / max limits I am still not sure how it should work. For some input fields, min / max values are adjusted directly after the Enter key.

If the values are very high then changing via arrow up / down is not possible. With my PR I have let this through.

image

@MewPurPur
Copy link
Contributor Author

Closing as superseded

@MewPurPur MewPurPur closed this Sep 3, 2023
@MewPurPur MewPurPur deleted the buff-editorspinslider-3 branch September 3, 2023 23:00
@AThousandShips AThousandShips removed this from the 4.2 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug topic:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MewPurPur @Alex2782 @akien-mga @YeldhamDev @AThousandShips