Fix position and size of MenuButton popup #78269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-menubutton-popup-position
branch
from
ae20fa2 to
0208ee2
Compare
akien-mga
approved these changes
Jun 15, 2023
|
Needs rebase. |
Use the same logic as in OptionButton::show_popup
Sauermann
force-pushed
the
fix-menubutton-popup-position
branch
from
0208ee2 to
d41665e
Compare
|
Thanks! |
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #76194
resolve part of #69749 (placement and size)
Use the same logic as in
OptionButton::show_popup, which got introduced in #69185Please don't merge at the same time as #78268 and merge after #78268.