Prevent nested packedArray from being casted to generic Arrays #76114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
changed the title
akien-mga
approved these changes
Apr 18, 2023
|
Does this still work correctly with regular and typed arrays? |
|
Yes this change only remove a forced cast from packed arrays to array |
|
Thanks! |
It doesn't work with typed arrays. |
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this pull request
May 31, 2023
Fixes to changes from godotengine#76114. This PR remove the hack with pointer and replace it with a proper handling from EditorPropertyNodePath of both NodePath and Node. Also needed to revise a bit the saving and loading of scene to handle properly the change. Fixes godotengine#74050. Fixes godotengine#74141. Fixes godotengine#75981. Fixes godotengine#76642. Revert "Fix typed array export... again" This reverts commit da8d673. Co-Authored-By: Tomek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76113