Fix range loop iteration regressions #72078
Conversation
|
All loops should iterate using references. Might be worth re-checking that PR if there aren't any more mistakes. |
|
Found another one in mesh_storage.cpp, but it looks like a inefficiency (copies insteads of references) rather than a behavior changing bug. I'll fix that too and update the PR once I have double checked everyting. |
bitsawer
force-pushed
the
fix_optimize_vertices
branch
from
afd96b5 to
8c25bcd
Compare
|
Went through the PR but those two issues are the only I could spot. Updated the PR and commit message. In one of the projects I have worked on we had a statical analyzer and rule that only allowed primitive types, references or pointers (const or not-const) in loops like that. It would also warn if a non-const loop value wasn't modified. I remember some people have run different analyzers on Godot source code in the past and reported bugs, could be useful. |
bitsawer
changed the title
|
Thanks! |
I think this PR (#70773) accidentally broke the vertex remapping. The old code wrote back the values (edge.vertex_a and edge.vertex_b), but the new code writes the values to a copy that is then thrown away. Haven't really fully figured how this affects the mesh optimization but I think this is a correct fix. @KoBeWi