Merge pull request #72078 from bitsawer/fix_optimize_vertices

Fix range loop iteration regressions
godotengine · Jan 26, 2023 · 31496c2 · 31496c2
2 parents 4b03633 + 8c25bcd
commit 31496c2
Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/math/geometry_3d.cpp b/core/math/geometry_3d.cpp
@@ -151,7 +151,7 @@ void Geometry3D::MeshData::optimize_vertices() {
 		}
 	}
 
-	for (MeshData::Edge edge : edges) {
+	for (MeshData::Edge &edge : edges) {
 		int a = edge.vertex_a;
 		int b = edge.vertex_b;
 

diff --git a/servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp b/servers/rendering/renderer_rd/storage_rd/mesh_storage.cpp
@@ -842,7 +842,7 @@ void MeshStorage::mesh_instance_set_blend_shape_weight(RID p_mesh_instance, int
 }
 
 void MeshStorage::_mesh_instance_clear(MeshInstance *mi) {
-	for (const RendererRD::MeshStorage::MeshInstance::Surface surface : mi->surfaces) {
+	for (const RendererRD::MeshStorage::MeshInstance::Surface &surface : mi->surfaces) {
 		if (surface.versions) {
 			for (uint32_t j = 0; j < surface.version_count; j++) {
 				RD::get_singleton()->free(surface.versions[j].vertex_array);