Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cases of broken user:// paths. #71396

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

reduz
Copy link
Member

@reduz reduz commented Jan 14, 2023

  • Properly validate paths when supplying the project name.
  • Ensures that the user data dir will always be valid.

Fixes #69366.

@reduz reduz requested a review from a team as a code owner January 14, 2023 14:09
@Chaosus Chaosus added this to the 4.0 milestone Jan 14, 2023
core/os/os.cpp Outdated Show resolved Hide resolved
* Properly validate paths when supplying the project name.
* Ensures that the user data dir will always be valid.

Fixes 69366.
@reduz reduz force-pushed the fix-broken-userdir branch from a9ee751 to 3a93efe Compare January 15, 2023 18:05
@reduz
Copy link
Member Author

reduz commented Jan 15, 2023

Changed approach so dots are treated as a special case (I still think this is pointless, this dir is pretty much invisible). If still not good, I accept suggestions.

@akien-mga akien-mga merged commit a3c8ba6 into godotengine:master Jan 21, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

naming project with file name with 2 or more prohibited characters causes user:// directory to not exist
3 participants