Never allow '..' in OS.get_safe_dir_name(), fixes minor security concern, add unit tests for it #65755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ern, add unit tests for it Previous behavior: '..' is allowed if 'allow_dir_separator' is false, which doesn't really make sense, I think it was a mistake in original implementation.
nathanfranke
force-pushed
the
never-allow-dot-dot
branch
from
010b824 to
9eff941
Compare
nathanfranke
changed the title
nathanfranke
commented
Sep 13, 2022
|
|
||
| // Never allow '..', it is dangerous! (whether that is an overstatement depends on the use case, but we should always be careful with user input). | ||
| CHECK_MESSAGE( | ||
| OS::get_singleton()->get_safe_dir_name("../../secret/files.txt") == "----secret-files.txt", |
There was a problem hiding this comment.
I think ---- makes sense, but if someone disagrees let me know here.
Suggested change
| OS::get_singleton()->get_safe_dir_name("../../secret/files.txt") == "----secret-files.txt", | |
| OS::get_singleton()->get_safe_dir_name("../../secret/files.txt") == "secret-files.txt", |
|
Won't this turn something like "a/../b" into "a/--/b" if |
|
Superseded by #71396. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior: '..' is allowed if 'allow_dir_separator' is false, which doesn't really make sense, I think it was a mistake in original implementation.