Make NavigationMeshGenerator independent from navigation module #70174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkKilauea
reviewed
Dec 17, 2022
servers/navigation/navigation_mesh_generator/navigation_mesh_generator.h
Outdated
Show resolved
Hide resolved
smix8
force-pushed
the
navigationmeshgenerator_independenceday_4.x
branch
2 times, most recently
from
dd3b7bc to
6ccbcd4
Compare
DarkKilauea
approved these changes
Dec 17, 2022
smix8
force-pushed
the
navigationmeshgenerator_independenceday_4.x
branch
2 times, most recently
from
68e8cbb to
37d4b8b
Compare
|
I haven't checked the changes in depth but this doesn't look good a priori. |
smix8
force-pushed
the
navigationmeshgenerator_independenceday_4.x
branch
from
37d4b8b to
a8cea3f
Compare
smix8
force-pushed
the
navigationmeshgenerator_independenceday_4.x
branch
2 times, most recently
from
edd1f98 to
8318bdd
Compare
Moves the NavigationMeshGenerator singleton out from Godot "navigation" module.
smix8
force-pushed
the
navigationmeshgenerator_independenceday_4.x
branch
from
8318bdd to
5d7df32
Compare
DarkKilauea
suggested changes
Dec 23, 2022
|
Superseded by #70724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
NavigationMeshGeneratorsingleton out from (godot) "navigation" module to its own module.This is an internal restructuring change to make other addons / modules / extensions and some further navigation developments possible.
The NavigationMeshGenerator is not only a singleton but also used across the engine for 3D (and soon 2D) while the "navigation" module is intended to be just one implementation for the NavigationServer that should be replaceable (soon) or open for gdextention in #69881.
The NavigationMeshGenerator as part of the module created odd dependency and init chains that required certain nodes like NavigationRegion3D to go through the NavigationServer API instead of working with the NavigationMeshGenerator directly e.g. for navigation mesh (re)baking. This was a roadblocker for other modules and extension that wanted to extend the navigation mesh baking system e.g. like Zylann's terrain module in #64682.