Enable GLES3 on Android #69355
Merged
Enable GLES3 on Android #69355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 29, 2022
akien-mga
reviewed
Nov 29, 2022
platform/android/java/lib/src/org/godotengine/godot/xr/regular/RegularContextFactory.java
Outdated
Show resolved
Hide resolved
akien-mga
reviewed
Nov 29, 2022
platform/android/java/lib/src/org/godotengine/godot/xr/regular/RegularContextFactory.java
Outdated
Show resolved
Hide resolved
akien-mga
reviewed
Nov 29, 2022
platform/android/java/lib/src/org/godotengine/godot/xr/regular/RegularConfigChooser.java
Outdated
Show resolved
Hide resolved
akien-mga
approved these changes
Nov 29, 2022
clayjohn
force-pushed
the
android-GLES3
branch
from
ff35435 to
ad5ac62
Compare
Add necessary build flags and switch from using a GLES2 context to a GLES3 one. This also enables building for OpenXR Co-authored-by: m4gr3d <[email protected]> Co-authored-by: dsnopek <[email protected]>
clayjohn
force-pushed
the
android-GLES3
branch
from
ad5ac62 to
9141984
Compare
|
@akien-mga Fixed all your nitpicks and made some other small variable name changes for tidiness. Thus should be ready to merge whenever |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add necessary build flags and switch from requesting a GLES2 context to requesting a GLES3 one. This also enables building for OpenXR
All of the heavy lifting was done by @m4gr3d and @dsnopek I just kind of flailed around until they fixed everything.
I've tested exporting a 2D app to android and it works fine. With heavier testing we may discover issues, but should merge for now.