Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add global:: namespace to generated source #69088

Merged
merged 1 commit into from
Nov 26, 2022
Merged

C#: Add global:: namespace to generated source #69088

merged 1 commit into from
Nov 26, 2022

Conversation

raulsntos
Copy link
Member

Adds global:: to the fully qualified types in source generators to prevent ambiguity.

@raulsntos raulsntos added this to the 4.0 milestone Nov 24, 2022
@raulsntos raulsntos requested a review from a team as a code owner November 24, 2022 01:40
@neikeq neikeq self-requested a review November 24, 2022 09:57
neikeq
neikeq reviewed Nov 25, 2022
View reviewed changes
Copy link
Contributor

@neikeq neikeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one concern. Everything else looks good.

modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ExtensionMethods.cs Outdated Show resolved Hide resolved
modules/mono/glue/GodotSharp/Godot.SourceGenerators.Internal/ExtensionMethods.cs Show resolved Hide resolved
@raulsntos
C#: Add global:: namespace to generated source
b9e1ca1 
Adds `global::` to the fully qualified types in source generators to
prevent ambiguity.
@neikeq neikeq merged commit 50badbd into godotengine:master Nov 26, 2022
@neikeq
Copy link
Contributor

neikeq commented Nov 26, 2022

Thanks!

@raulsntos raulsntos deleted the dotnet/global branch November 26, 2022 04:02
@neikeq neikeq mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neikeq neikeq neikeq approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Godot fails to compile nested recursive namespace names with cryptic error messages
2 participants
@raulsntos @neikeq