Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot fails to compile nested recursive namespace names with cryptic error messages #69038

Closed
LouisIngenthron opened this issue Nov 23, 2022 · 2 comments · Fixed by #69088
Closed

Comments

@LouisIngenthron
Copy link

LouisIngenthron commented Nov 23, 2022

Godot version

v4.0.beta5.mono.official [89a33d2]

System information

Windows 10 x64

Issue description

If you add a C# script with nesting namespace lines that use the same name as a higher namespace name, Godot fails to compile, but gives an odd error about Godot.SourceGenerators temporary files instead of the problem file in question.

Steps to reproduce

To reproduce the error, just add the below class to a C# script in a Godot 4 project and then reference that class in any other script and click build:

using Godot;

namespace SpaceA.SpaceB
{
    namespace SpaceA
    {
        public partial class Foo : Node {}
    }
}

Minimal reproduction project

BugReport.zip

@adamscott
Copy link
Member

adamscott commented Nov 23, 2022

To cite CONTRIBUTING.md

On the contributors' end, recreating a test project from scratch takes valuable time that can be saved by uploading a minimal project.

To speed up our work, please upload a minimal project that isolates and reproduces the issue. This is always the best way for us to fix it. We recommend attaching a ZIP file with the minimal project directly to the bug report, by drag and dropping the file in the GitHub edition field. This ensures the file can remain available for a long period of time. Only use third-party file hosts if your ZIP file isn't accepted by GitHub because it's too large.

We recommend always attaching a minimal reproduction project, even if the issue may seem simple to reproduce manually.

If you've been asked by a maintainer to upload a minimal reproduction project, you must do so within 7 days. Otherwise, your bug report will be closed as it'll be considered too difficult to diagnose.

Please upload a MRP to the issue's description.

@LouisIngenthron
Copy link
Author

Updated original post per request.

@raulsntos raulsntos moved this from To Assess to In Progress in 4.x Priority Issues Nov 24, 2022
Repository owner moved this from In Progress to Done in 4.x Priority Issues Nov 26, 2022
@raulsntos raulsntos modified the milestones: 4.x, 4.0 Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants