-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix physics events being interpreted twice for nodes in canvas layer #66076
Fix physics events being interpreted twice for nodes in canvas layer #66076
Conversation
cbbb2af
to
f3fecd0
Compare
f3fecd0
to
ca1272f
Compare
I have updated the PR according to the discussion with @rburing on 2022-12-05 in the Physics-channel (https://chat.godotengine.org/channel/physics?msg=pxMvfyFwZWch953dk) |
ca1272f
to
f18c898
Compare
I'd prefer to just remove the special treatment of That would break compatibility for people using |
f18c898
to
7e056f1
Compare
The original version of the PR can be seen at cbbb2af (not sure how long github keeps this cached version). I have reverted the PR to the original version and updated the docs to additionally describe the case |
Thanks! |
resolve #64652
Currently
GodotPhysicsDirectSpaceState2D::intersect_point
returns, when given the default viewport canvas layer as argument, alsoShapeResult
s that belong to other canvas layers within the current viewport.Since canvas layer of these nodes can have a different transform, they may not intersect with the given point.
This patch introduces an additional parameter to
PhysicsPointQueryParameters2D
, which governs howcanvas_instance_id == 0
should be handled.Updated 2022-12-12: Fix merge conflict