Add initial ies lights. #63835

fire · 2022-08-02T17:20:03Z

Fixes: godotengine/godot-proposals#715

Status:

Copyright handling

Imports something into an image. Not sure how projectors work.

Part of the V-Sekai project. https://github.com/v-sekai

jcostello · 2022-08-02T18:34:19Z

How does it works?

fire · 2022-08-02T18:37:04Z

I currently have generated a 521x1 strip.

My next task is to convert that to a cube map.

float interpolate2D(const IESFileInfo& info, float angleV, float angleH) const;

Assistance helpful.

fire · 2022-08-02T19:14:30Z

@clayjohn Said he'll describe how to integrate with the light projectors.

// From the original guide
// hlsl
float3 ComputeIESLightProfile1D(float3 L, float3 LightDirection)
{
    L = mul(L, (float3x3)matViewInverse);
    float angle = (1 - acos(dot(L, LightDirection)) / PI);
    return tex2Dlod(IESTextureSamp, float4(angle, 0, 0, 0)).rgb;
}

reduz · 2022-08-11T13:09:32Z

modules/gridmap/grid_map.cpp

 				// add navigation debugmesh visual instances if debug is enabled
 				SceneTree *st = SceneTree::get_singleton();
 				if (st && st->is_debugging_navigation_hint()) {
 					if (!nm.navmesh_debug_instance.is_valid()) {
-						RID navmesh_debug_rid = navmesh->get_debug_mesh()->get_rid();
+						RID navmesh_debug_rid = navmesh->_get_debug_mesh()->get_rid();


seems unrelated?

reduz · 2022-08-11T13:10:20Z

This looks good, why a draft?

akien-mga · 2022-08-11T13:13:51Z

modules/ies/image_loader_ies.cpp

+#include "core/string/ustring.h"
+
+#include "thirdparty/ies/ies_loader.h"
+#include <ios>


What needs this? I only see std::string.

thirdparty/README.md

akien-mga · 2022-08-11T13:16:09Z

thirdparty/ies/ies_loader.h

+	static void getInt(const std::string& data, std::string& next, std::int32_t& ret, bool stopOnWhiteSpace = true, bool stopOnComma = false);
+};
+
+#endif


Missing newline at EOF.

akien-mga · 2022-08-11T13:16:19Z

thirdparty/ies/ies_loader.cpp

+	getLineContent(data, next, line, stopOnWhiteSpace, stopOnComma);
+	assert(!line.empty());
+	ret = std::atoi(line.c_str());
+}


Missing newline.

akien-mga · 2022-08-11T13:16:58Z

thirdparty/README.md

+- License: MIT
+
+See the standard from https://github.com/ray-cast/ies/blob/master/IES.pdf and from http://www.tc.faa.gov/its/worldpac/Standards/ansi/ansi-ies%20rp-1-04.pdf


Suggested change

- License: MIT

See the standard from https://github.com/ray-cast/ies/blob/master/IES.pdf and from http://www.tc.faa.gov/its/worldpac/Standards/ansi/ansi-ies%20rp-1-04.pdf

- License: MIT

Files extracted from upstream source:

- `ies_loader.{cpp,h}`

- `LICENSE.txt`

See the standard from https://github.com/ray-cast/ies/blob/master/IES.pdf and from http://www.tc.faa.gov/its/worldpac/Standards/ansi/ansi-ies%20rp-1-04.pdf

COPYRIGHT.txt

fire · 2022-08-11T17:09:13Z

@reduz I wasn't sure how to take the 1x512 px image and turn it into a projection that Godot can use for cookie lighting.

Calinou · 2022-08-11T17:10:54Z

I wasn't sure how to take the 1x512 px image and turn it into a projection that Godot can use for cookie lighting.

OmniLights use a texture with spherical projection (like HDRI panoramas, but upside down). SpotLights use box texture projection in the direction the SpotLight is pointing towards.

You should be able to correct the OmniLight projector's perspective using a polar to cartesian (or cartesian to polar) function.

jcostello · 2022-08-11T17:16:24Z

Please ensure that this feature works with static lights when baking lightmaps

fire · 2022-08-11T17:43:57Z

@jcostello I do not know if projectors bake. The goal of this pr is to generate a image that can be loaded by the light cookie projector.

jcostello · 2022-08-11T19:16:25Z

@fire projectors seems to not be working at the moment

#59488

akien-mga · 2022-09-01T15:34:33Z

modules/gridmap/grid_map.cpp

 				// add navigation debugmesh visual instances if debug is enabled
 				SceneTree *st = SceneTree::get_singleton();
 				if (st && st->is_debugging_navigation_hint()) {
 					if (!nm.navmesh_debug_instance.is_valid()) {
-						RID navmesh_debug_rid = navmesh->get_debug_mesh()->get_rid();
+						RID navmesh_debug_rid = navmesh->_get_debug_mesh()->get_rid();


Unrelated, should be removed (you can open an issue about what that bug is because it's weird you keep changing it - but I suspect you might be working off a slightly outdated master branch if this breaks).

This happens on all my rebases up to last night. I also have the same error on ming-llvm and osx's clang.

Co-authored-by: Rémi Verschelde <[email protected]>

fire · 2022-09-07T06:45:46Z

This is salvageable. Will need to re-evaluate in 4.x

fire force-pushed the ies-lights branch 3 times, most recently from 1414a5b to f4f9f98 Compare August 2, 2022 18:09

Calinou added enhancement topic:rendering topic:import topic:3d labels Aug 2, 2022

Calinou added this to the 4.0 milestone Aug 2, 2022

fire force-pushed the ies-lights branch 4 times, most recently from 036f62e to 74eed9e Compare August 2, 2022 18:27

fire force-pushed the ies-lights branch 2 times, most recently from bc48fc7 to dd56013 Compare August 2, 2022 18:53

Add ies lights.

70b6685

fire force-pushed the ies-lights branch from dd56013 to 70b6685 Compare August 2, 2022 19:12

reduz requested changes Aug 11, 2022

View reviewed changes

akien-mga requested changes Aug 11, 2022

View reviewed changes

fire mentioned this pull request Aug 24, 2022

Vulkan: SpotLight3D's Projector doesn't work (regression from 4.0.alpha5 and later) #59488

Closed

akien-mga reviewed Sep 1, 2022

View reviewed changes

akien-mga removed this from the 4.0 milestone Sep 1, 2022

akien-mga added this to the 4.x milestone Sep 1, 2022

fire and others added 3 commits September 1, 2022 08:57

Update COPYRIGHT.txt

034da15

Co-authored-by: Rémi Verschelde <[email protected]>

Update thirdparty/README.md

a8bd043

Co-authored-by: Rémi Verschelde <[email protected]>

Update thirdparty/README.md

541c47c

Co-authored-by: Rémi Verschelde <[email protected]>

fire closed this Sep 7, 2022

akien-mga added archived salvageable labels Sep 7, 2022

aaronfranke removed this from the 4.x milestone Feb 1, 2023

This comment was marked as off-topic.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial ies lights. #63835

Add initial ies lights. #63835

fire commented Aug 2, 2022 •

edited

Loading

jcostello commented Aug 2, 2022

fire commented Aug 2, 2022

fire commented Aug 2, 2022

reduz Aug 11, 2022

reduz commented Aug 11, 2022

akien-mga Aug 11, 2022

akien-mga Aug 11, 2022

akien-mga Aug 11, 2022

akien-mga Aug 11, 2022

fire commented Aug 11, 2022

Calinou commented Aug 11, 2022 •

edited

Loading

jcostello commented Aug 11, 2022

fire commented Aug 11, 2022

jcostello commented Aug 11, 2022

akien-mga Sep 1, 2022

fire Sep 1, 2022

fire commented Sep 7, 2022

This comment was marked as off-topic.

		- License: MIT

		See the standard from https://github.com/ray-cast/ies/blob/master/IES.pdf and from http://www.tc.faa.gov/its/worldpac/Standards/ansi/ansi-ies%20rp-1-04.pdf

Add initial ies lights. #63835

Add initial ies lights. #63835

Conversation

fire commented Aug 2, 2022 • edited Loading

jcostello commented Aug 2, 2022

fire commented Aug 2, 2022

fire commented Aug 2, 2022

reduz Aug 11, 2022

Choose a reason for hiding this comment

reduz commented Aug 11, 2022

akien-mga Aug 11, 2022

Choose a reason for hiding this comment

akien-mga Aug 11, 2022

Choose a reason for hiding this comment

akien-mga Aug 11, 2022

Choose a reason for hiding this comment

akien-mga Aug 11, 2022

Choose a reason for hiding this comment

fire commented Aug 11, 2022

Calinou commented Aug 11, 2022 • edited Loading

jcostello commented Aug 11, 2022

fire commented Aug 11, 2022

jcostello commented Aug 11, 2022

akien-mga Sep 1, 2022

Choose a reason for hiding this comment

fire Sep 1, 2022

Choose a reason for hiding this comment

fire commented Sep 7, 2022

This comment was marked as off-topic.

fire commented Aug 2, 2022 •

edited

Loading

Calinou commented Aug 11, 2022 •

edited

Loading