Vulkan: SpotLight3D's Projector doesn't work (regression from 4.0.alpha5 and later)

[macryc]

Godot version

4.0 alpha 5

System information

Win10, GLES3, RTX 2070 mobile

Issue description

SpotLight3D's Projector doesn't work. Worked fine in alpha 4, stopped in alpha 5.

Steps to reproduce

Create a 3d scene
add spotlight3d
add texture2d to projector slot
enable shadows on spotlight
put in a 3d mesh to cast spotlight on

Minimal reproduction project

No response

[Calinou]

@macryc Please upload a minimal reproduction project to make this easier to troubleshoot.

[macryc]

spotlight3d.zip

[Calinou]

I can confirm this on 9923179 (Linux, NVIDIA 510.68.02). OmniLight3D projectors also don't work. This bug occurs in both Vulkan Clustered and Vulkan Mobile backends.

An interesting thing is that the decal atlas appears broken after you reload the project:

Testing project: https://0x0.st/oaSJ.zip

[Calinou]

I bisected the regression to 57e5a33. cc @BastiaanOlij

[BastiaanOlij]

Hmm, I must have messed something up when moving all the code related to this into the new TextureStorage class. I'll have a closer look as soon as I've finished with the GI changes.

[fire]

Add initial ies lights #63835 is dependent on this.

[kidinashell]

Currently still no change (in 4.0 beta1) when using projector textures (plain lighting as per default) @BastiaanOlij Would this be something you could want some help with? I've never contributed to the project myself so I would have to look into the structure of things and regulations but I would like to fix this if possible.

[fire]

@clayjohn May be able to assist @kidinashell

[clayjohn]

Currently still no change (in 4.0 beta1) when using projector textures (plain lighting as per default) @BastiaanOlij Would this be something you could want some help with? I've never contributed to the project myself so I would have to look into the structure of things and regulations but I would like to fix this if possible.

@kidinashell Feel free to work on this, Bastiaan is quite busy with some other work right now.

To help you get started, projector textures were added in #37887. This should give you an idea about how they should work.

Calinou bisected the regression to 57e5a33 so the bug was introduced by something that Bastiaan changed in 57e5a33. Looking between Juan's PR and Bastiaan's commit you should be able to find out what went wrong.

As for contributing, we have a whole section of the docs dedicated to documenting helpful things to know as you get started contributing.

Also feel free to ask questions. You can reach both Bastiaan and I quite easily on the rendering channel on Godot's contributor chat.

[BastiaanOlij]

Sorry guys, totally lost track of this one. Yeah I'm heads down bum up in further reorg stuff so I could definitely use an extra set of eyes on this one. As the commit that seems to have broken this mostly moves stuff into new classes it's likely a simple issue with a RID getting mixed up or a setting getting reversed.

[kidinashell]

@BastiaanOlij Did a PR #66065 for this after looking around the renderer section and it's ready for review. Hope it helps.