Remove Signal connect binds #63595
Merged
Remove Signal connect binds #63595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Jul 28, 2022
KoBeWi
reviewed
Jul 28, 2022
KoBeWi
reviewed
Jul 28, 2022
KoBeWi
reviewed
Jul 28, 2022
reduz
force-pushed
the
remove-signal-connect-binds
branch
from
0d49810 to
1de3d3a
Compare
reduz
force-pushed
the
remove-signal-connect-binds
branch
from
1de3d3a to
ea8fd0e
Compare
reduz
force-pushed
the
remove-signal-connect-binds
branch
2 times, most recently
from
ea28331 to
5718741
Compare
KoBeWi
approved these changes
Jul 29, 2022
akien-mga
reviewed
Jul 29, 2022
akien-mga
reviewed
Jul 29, 2022
akien-mga
reviewed
Jul 29, 2022
akien-mga
reviewed
Jul 29, 2022
Remove the optional argument p_binds from `Object::connect` since it was deprecated by Callable.bind(). Changed all uses of it to Callable.bind()
reduz
force-pushed
the
remove-signal-connect-binds
branch
from
5718741 to
d4433ae
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the optional argument p_binds from
Object::connectsince it was deprecated by Callable.bind().Changed all uses of it to Callable.bind()
This is the final part of the work started by #36368, #36393 and #42683 (and further work by Kobewi) to replace the signal system by one made entirely with callables.
NOTE: The documentation in
Object.connectis now outdated and, because its not trivial, its probably better the documentation team rewrites this and the examples (which are already in part outdated in the C# side).