Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C# signal documentation and remove bind array #64930

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Update C# signal documentation and remove bind array #64930

merged 1 commit into from
Jan 24, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Aug 26, 2022 •
edited
Loading

@raulsntos raulsntos added this to the 4.0 milestone Aug 26, 2022
@raulsntos raulsntos requested a review from a team as a code owner August 26, 2022 14:24
@raulsntos raulsntos mentioned this pull request Aug 26, 2022
Merged
@raulsntos raulsntos marked this pull request as draft August 27, 2022 00:44
@raulsntos
Copy link
Member Author

raulsntos commented Aug 27, 2022 •
edited
Loading

Marking as draft because there might still be changes to the C# Callable implementation (for starters, Callable.Bind is not implemented so this doc is currently wrong).

Edit: Changes to C# Callable (#67987) have been merged, but Callable.Bind is still not implemented so leaving as draft for now.

@MJacred

This comment was marked as off-topic.

Sign in to view
magian1127
magian1127 reviewed Sep 7, 2022
View reviewed changes
doc/classes/Object.xml Outdated Show resolved Hide resolved
@raulsntos raulsntos mentioned this pull request Sep 19, 2022
Closed
@raulsntos raulsntos mentioned this pull request Nov 24, 2022
Closed
@raulsntos raulsntos mentioned this pull request Jan 23, 2023
Closed
@akien-mga
Copy link
Member

Would be good to finalize and merge this soon :)

@raulsntos raulsntos marked this pull request as ready for review January 23, 2023 15:43
@raulsntos
Copy link
Member Author

Rebased and removed Bind and Unbind from the C# documentation since it's not implemented, we can add it back if/when it's added to C#.

@raulsntos
Update C# signal documentation and remove bind array
92e4b4e 
- Updates C# signal documentation and code examples to the new API in 4.0
- Replace all `nameof` usages with the exposed `StringName`
raulsntos
raulsntos commented Jan 23, 2023
View reviewed changes
doc/classes/Callable.xml
{
GD.PrintS(arg1, arg2, arg3);
}

public void Test()
{
Callable callable = new Callable(this, nameof(PrintArgs));
callable.Call("hello", "world"); // Prints "hello world null".
// Invalid calls fail silently.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because of #59830.

@akien-mga akien-mga merged commit 4fa6edc into godotengine:master Jan 24, 2023
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/docs branch January 24, 2023 12:47
@MikeSchulze MikeSchulze mentioned this pull request Jun 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magian1127 magian1127 magian1127 left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation topic:dotnet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

4.0 C# Signal.Connect Doesn't Work as Documented in Object.Connect Documentation
4 participants
@raulsntos @MJacred @akien-mga @magian1127