Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ballhead constraints for FABRIK #61994

Closed
wants to merge 2 commits into from
Closed

Ballhead constraints for FABRIK #61994

wants to merge 2 commits into from

Conversation

KaruroChori
Copy link

@KaruroChori KaruroChori commented Jun 13, 2022

Not to be merged yet, as I have not been able to really test its functionality.

godotengine/godot-proposals#750 (comment)
The author referenced a solution of ballhead constraint on the inverse kinematic model for FABRIK. I just ported its code and integrated it in the GUI of Godot.

Any external evaluation is very welcome.

@Calinou
Copy link
Member

Calinou commented Jun 13, 2022

This PR includes unrelated commits such as aa58cc6 (#61994). You probably created a branch on your fork based on an existing branch with commits on top.

@KaruroChori
Copy link
Author

It seems to be accurate :/. I guess this is what happens working on two things at the same time and being me 😄 .

I'm not really sure how to address this now, I should have generated a different branch since the very beginning also for the other pull request to avoid any interference.
I am not very accustomed contributing on public repositories, sorry if miss some aspects of the proper workflow.

@KaruroChori
Copy link
Author

In theory, I solved it.

@fire
Copy link
Member

fire commented Jun 13, 2022

The pr currently has some wrong formatting.

Check https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html

@KaruroChori
Copy link
Author

In theory, I had my branch reverted to a commit which was part of master, and applied any relevant change from scratch. The history of commits seems clean as far as I can tell. Could you explain what is the problem specifically?

Or were you referring to the code itself?

@KaruroChori KaruroChori requested review from a team as code owners June 13, 2022 15:50
@KaruroChori
Copy link
Author

KaruroChori commented Jun 13, 2022

It seems like the automatic execution of clang_format.sh I performed is trying to change additional files that I never touched. Some of those changes make sense, like removing trailing spaces, some others do not, like the newline escape sequence for defines. Was that expected behaviour?

@KaruroChori
Copy link
Author

Close to ensure a better adherence to the git guidelines of godot.

@Calinou
Copy link
Member

Calinou commented Jun 13, 2022

Superseded by #62003.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants